Dev 6 #2
Closed
Dev 6 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by protecting against sb->s_shrink eviction on umount with newer kernels deactivate_locked_super calls shrinker_free and only then sops->kill_sb cb, resulting in UAF on umount when trying to reach for the shrinker functions in zpl_prune_sb of in-umount dataset Signed-off-by: Pavel Snajdr <snajpa@snajpa.net>
Signed-off-by: Pavel Snajdr <snajpa@snajpa.net>
Other linux fs implementations seem to hold a reference to some buffer which seems to cause the inode to stay in place in tight memory conditions. Replicate such behavior. Signed-off-by: Pavel Snajdr <snajpa@snajpa.net>
Commit message TODO Signed-off-by: Pavel Snajdr <snajpa@snajpa.net>
This should avoid this VERIFY trip: VERIFY3(tx->tx_txg <= spa_final_dirty_txg(os->os_spa)) failed (63 <= 62 PANIC at dbuf.c:2324:dbuf_dirty() Showing stack for process 587858 CPU: 1 PID: 587858 Comm: txg_sync Tainted: P OE 6.10.12- Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian- Call Trace: <TASK> dump_stack_lvl+0x64/0x80 spl_panic+0x100/0x120 [spl] dbuf_dirty+0xd5a/0x1300 [zfs] ? srso_alias_return_thunk+0x5/0xfbef5 ? dmu_buf_will_dirty_impl+0xdf/0x330 [zfs] spa_history_log_sync+0x11e/0x620 [zfs] ? srso_alias_return_thunk+0x5/0xfbef5 ? list_head+0x9/0x30 [zfs] ? srso_alias_return_thunk+0x5/0xfbef5 ? srso_alias_return_thunk+0x5/0xfbef5 ? __cv_destroy+0x92/0x250 [spl] ? srso_alias_return_thunk+0x5/0xfbef5 ? mutex_lock+0x12/0x30 dsl_sync_task_sync+0xb9/0x120 [zfs] dsl_pool_sync+0x4c7/0x6a0 [zfs] spa_sync_iterate_to_convergence+0xd8/0x320 [zfs] spa_sync+0x308/0x8e0 [zfs] ? __wake_up+0x44/0x60 txg_sync_thread+0x272/0x3c0 [zfs] ? __pfx_txg_sync_thread+0x10/0x10 [zfs] ? __pfx_thread_generic_wrapper+0x10/0x10 [spl] thread_generic_wrapper+0x66/0x90 [spl] kthread+0xd2/0x100 ? __pfx_kthread+0x10/0x10 ret_from_fork+0x34/0x50 ? __pfx_kthread+0x10/0x10 ret_from_fork_asm+0x1a/0x30 </TASK> Signed-off-by: Pavel Snajdr <snajpa@snajpa.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by.