Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Tests and Github Actions Step for Unit Tests #37

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Add Unit Tests and Github Actions Step for Unit Tests #37

wants to merge 13 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Oct 30, 2023

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This PR adds unit tests for the InfluxDBReporter class in the src/influxdb-reporter.js file. The tests cover all public methods of the class and include test cases for various scenarios and edge cases. Additionally, a new step is added to the Github Actions workflow file .github/workflows/main.yml to run the unit tests as part of the CI/CD pipeline.

Summary of Changes

  • Created a new test file test/influxdb-reporter.test.js to write unit tests for the InfluxDBReporter class.
  • Imported the InfluxDBReporter class from src/influxdb-reporter.js in the test file.
  • Used Jest as the testing framework to write comprehensive unit tests for all public methods of the InfluxDBReporter class.
  • Added a new step in the Github Actions workflow file .github/workflows/main.yml to run the unit tests using the npm test command.
  • Ensured that the unit tests are executed after the build step and before any deployment steps in the workflow.

Please review the changes and merge this PR to include unit tests and the Github Actions step for running the tests in the CI/CD pipeline.

Fixes #35.

🎉 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai
Copy link
Contributor Author

sweep-ai bot commented Oct 30, 2023

Sandbox Executions

  • Check test/influxdb-reporter.test.js ✓
Sandbox logs for https://github.com/vs4vijay/newman-reporter-influxdb/commit/c39c94747d61f1f3babdccd1e5012914dfd6ddf9
npm i 1/4 ✓ 
npm WARN old lockfile 
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile 
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile 
added 2 packages, and audited 3 packages in 744ms
1 package is looking for funding
  run `npm fund` for details
2 high severity vulnerabilities
To address all issues, run:
  npm audit fix
Run `npm audit` for details.
trunk init 2/4 ✓ 
⡿ Downloading Trunk 1.17.1...
⡿ Downloading Trunk 1.17.1...
⢿ Downloading Trunk 1.17.1...
⣻ Downloading Trunk 1.17.1...
⣽ Downloading Trunk 1.17.1...
⣾ Downloading Trunk 1.17.1...
⣷ Downloading Trunk 1.17.1...
✔ Downloading Trunk 1.17.1... done
⡿ Verifying Trunk sha256...
✔ Verifying Trunk sha256... done
⡿ Unpacking Trunk...
✔ Unpacking Trunk... done


✔ 10 linters were enabled (.trunk/trunk.yaml)
  actionlint 1.6.26 (1 github-workflow file)
  checkov 3.0.12 (4 json, 2 yaml files)
  git-diff-check (14 files)
  markdownlint 0.37.0 (1 markdown file) (created .markdownlint.yaml)
  osv-scanner 1.4.2 (1 lockfile file)
  prettier 3.0.3 (4 javascript, 3 json, 1 markdown, 2 yaml files)
  renovate 37.8.1 (1 renovate-config file)
  trivy 0.46.0 (2 yaml files)
  trufflehog 3.60.4 (15 files)
  yamllint 1.32.0 (2 yaml files) (created .yamllint.yaml)
Next Steps
 1. Read documentation
    Our documentation can be found at https://docs.trunk.io
 2. Get help and give feedback
    Join the Trunk community at https://slack.trunk.io
trunk fmt test/influxdb-reporter.test.js || exit 0 3/4 ✓ 
 ✔ Formatted test/influxdb-reporter.test.js
Re-checking autofixed files...


Checked 1 file
✔ No issues
trunk check --fix --print-failures test/influxdb-reporter.test.js 4/4 ✓ 
Checked 1 file
✔ No issues
  • Check .github/workflows/main.yml ✗
Sandbox logs for
trunk fmt .github/workflows/main.yml || exit 0 1/2 ✓ 
 ✔ Formatted .github/workflows/main.yml
Re-checking autofixed files...


Checked 1 file
✔ No issues
trunk check --fix --print-failures .github/workflows/main.yml 2/2 ❌ (`1`) 
  ISSUES  
.github/workflows/main.yml:1:1
 1:1  high  Ensure top-level permissions are not set to write-all  checkov/CKV2_GHA_1
Checked 1 file
✖ 1 new issue
  • Check .github/workflows/main.yml ✗
Run .github/workflows/main.yml through the sandbox.
  • Check .github/workflows/main.yml ✗
Sandbox logs for
trunk fmt .github/workflows/main.yml || exit 0 1/2 ✓ 
 ✔ Formatted .github/workflows/main.yml
Re-checking autofixed files...


Checked 1 file
✔ No issues
trunk check --fix --print-failures .github/workflows/main.yml 2/2 ❌ (`1`) 
  ISSUES  
.github/workflows/main.yml:1:1
 1:1  high  Ensure top-level permissions are not set to write-all  checkov/CKV2_GHA_1
Checked 1 file
✖ 1 new issue

@sweep-ai
Copy link
Contributor Author

sweep-ai bot commented Oct 30, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sweep-ai sweep-ai bot added the sweep Sweep your software chores label Oct 30, 2023
@sweep-ai sweep-ai bot mentioned this pull request Oct 30, 2023
Open
6 tasks
hound[bot]
hound bot reviewed Oct 30, 2023
View reviewed changes
test/influxdb-reporter.test.js
});
});

describe("request", () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').
Too many errors. (73% scanned).

test/influxdb-reporter.test.js
const item = {
/* some item */
};
reporter.beforeItem(null, { item });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'object short notation' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

test/influxdb-reporter.test.js

describe("beforeItem", () => {
it("updates the context correctly", () => {
const item = {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

test/influxdb-reporter.test.js
});

describe("beforeItem", () => {
it("updates the context correctly", () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

test/influxdb-reporter.test.js
});
});

describe("beforeItem", () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

test/influxdb-reporter.test.js
});
});

beforeEach(() => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

test/influxdb-reporter.test.js

describe("done", () => {
it("disconnects the service correctly", () => {
const disconnect = jest.spyOn(reporter.service, "disconnect");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

test/influxdb-reporter.test.js
});

describe("done", () => {
it("disconnects the service correctly", () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

test/influxdb-reporter.test.js
});
});

describe("done", () => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'arrow function syntax (=>)' is only available in ES6 (use 'esversion: 6').

test/influxdb-reporter.test.js
/* some item */
};
reporter.context.currentItem = item;
const sendData = jest.spyOn(reporter.service, "sendData");
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'const' is available in ES6 (use 'esversion: 6') or Mozilla JS extensions (use moz).

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
72.4% 72.4% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hound hound[bot] hound left review comments

Assignees
No one assigned
Labels
sweep Sweep your software chores
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sweep: Write Unit Tests and Add a step to run Unit Tests in Github Actions
0 participants