Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use patch to update resources managed in external repos #47

Open
bastjan opened this issue Mar 24, 2023 · 0 comments
Open

Use patch to update resources managed in external repos #47

bastjan opened this issue Mar 24, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@bastjan
Copy link
Contributor

bastjan commented Mar 24, 2023

Description

If not kept in sync with https://github.com/appuio/cloud-portal this adapter will delete fields from the stored Organizations.

if err := r.Update(ctx, org); err != nil {

should minimally updated to use server side merge so we don't have to be extra cautious to keep this adapter in sync.

Additional Context

No response

Logs

No response

Expected Behavior

Controller uses server side merge for organizations.

Steps To Reproduce

  • Use version < v0.6.0
  • Set .spec.billingEntityRef on an organization
  • Delete organization finalizer
  • .spec.billingEntityRef disappears

Versions

all

@bastjan bastjan added the bug Something isn't working label Mar 24, 2023
@bastjan bastjan changed the title Use patch to update resources managed in external repo Use patch to update resources managed in external repos Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant