Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening links in release notes in new window of the default browser #177

Closed
pparekh7 opened this issue Aug 20, 2018 · 5 comments
Closed

Comments

@pparekh7
Copy link

I'm using WinSparkle 0.6.0 and currently testing our app on a Windows 10 system. We have a link in our release notes that when clicked displays the page using the browser control. What I would like is for it to open in a new window of the default browser.

I've played with a couple of apps that use WinSparkle and they both have the expected behavior. I can't seem to find an obvious way to configure this behavior. Can anyone point me in the correct direction?

Thanks,
Priyanka

@vslavik
Copy link
Owner

vslavik commented Aug 21, 2018

target="_blank" as in every single other browser in existence.

@vslavik vslavik closed this as completed Aug 21, 2018
@geraldcombs
Copy link

target="_blank" as in every single other browser in existence.

...except Sparkle's: sparkle-project/Sparkle#430. This was an issue for us because we use the same release notes for both Sparkle and WinSparkle. We worked around it by using a conditional comment:

<!--[if IE]><base target="_blank"><![endif]-->

@vslavik
Copy link
Owner

vslavik commented Jan 16, 2020

I’m pretty sure I used target="_blank" with Sparkle in the past, but I may be mistaken. This of course changes the situation, reopening.

@vslavik vslavik reopened this Jan 16, 2020
@vslavik
Copy link
Owner

vslavik commented Feb 12, 2020

So, this is one of those things that are much more complicated than they sound: https://stackoverflow.com/questions/2925279/iwebbrowser2-how-to-force-links-to-open-in-new-window

Using DISPID_BEFORENAVIGATE2 may be OK in the limited situation of release notes. There's a more complicated solution described in the above link too.

@vslavik
Copy link
Owner

vslavik commented Oct 18, 2022

Note also that it appears that target="_blank" launches MSIE, not user's default browser, when using the WebBrowser control - see #227 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants