From 1dcfd59cd07111131d2d27358390bef7238aeb18 Mon Sep 17 00:00:00 2001
From: toshski <toshski8760@gmail.com>
Date: Tue, 30 Jul 2024 08:46:16 +1200
Subject: [PATCH] Add checks to migration and retry if they fail

---
 pkg/migrations/migrations.go | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/pkg/migrations/migrations.go b/pkg/migrations/migrations.go
index 71c99d168..8b8419b11 100644
--- a/pkg/migrations/migrations.go
+++ b/pkg/migrations/migrations.go
@@ -53,6 +53,7 @@ func (i *RequestSceneList) ToJSON() string {
 }
 
 func Migrate() {
+	var retryMigration []string
 	db, _ := models.GetDB()
 
 	m := gormigrate.New(db, gormigrate.DefaultOptions, []*gormigrate.Migration{
@@ -1967,7 +1968,21 @@ func Migrate() {
 			// remove unreferenced tags created due to an error
 			ID: "0079-remove-unreferenced-tags",
 			Migrate: func(tx *gorm.DB) error {
+				// update tag counts
 				tasks.CountTags()
+
+				// check there are no Tags with a count of 0 that are in use, should not happen if CountTags is working properly,
+				//  but don't want to risk a referential integrity issue
+				type tagsInUse struct {
+					Cnt int
+				}
+				var result tagsInUse
+				db.Raw("select count(*) as cnt from scene_tags st join scenes s on s.id=st.scene_id join tags t on t.id=st.tag_id where t.`count` = 0 and s.deleted_at is NULL").Scan(&result)
+				if result.Cnt > 0 {
+					// this should never happen, but not deleting unreferenced tags will not break the system, so don't fail the migration, flag it to retry
+					retryMigration = append(retryMigration, "0079-remove-unreferenced-tags")
+					return nil
+				}
 				return tx.Model(&models.Tag{}).Exec("delete from tags where `count` = 0").Error
 			},
 		},
@@ -1976,6 +1991,15 @@ func Migrate() {
 	if err := m.Migrate(); err != nil {
 		common.Log.Fatalf("Could not migrate: %v", err)
 	}
+	if len(retryMigration) > 0 {
+		for _, migration := range retryMigration {
+			common.Log.Warnf("*** MIGRATION WARNING ***: Could not migrate: '%v', this migration will retry the next time XBVR is started", migration)
+			err := db.Exec("DELETE FROM migrations WHERE id = ?", migration).Error
+			if err != nil {
+				common.Log.Fatalf("Failed to remove %v from the miigration table - will not be retried", err)
+			}
+		}
+	}
 	common.Log.Printf("Migration did run successfully")
 
 	db.Close()