Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails in iOS 10.0.2 in private mode on Chrome and Safari, private mode in macOS Safari #62

Closed
3vivekb opened this issue Oct 20, 2016 · 4 comments
Assignees

Comments

@3vivekb
Copy link

3vivekb commented Oct 20, 2016

When you try to use the tripplanner in:
macOS Sierra: Safari Private Mode
iPhone: Chrome incognito
iPhone: Safari private mode

The app fails to load a trip.
screen shot 2016-10-20 at 2 51 37 pm

It probably has to do with:
this Thanks @clarle

@clarle
Copy link

clarle commented Oct 20, 2016

❤️ 📱 🐛

@clarle
Copy link

clarle commented Oct 20, 2016

FYI this happens with both localStorage and sessionStorage:

screen shot 2016-10-20 at 3 21 41 pm

You'd need to check how sessionStorage is accessed in #14 and fallback if sessionStorage isn't accessible.

@3vivekb
Copy link
Author

3vivekb commented Oct 27, 2016

We could, as a workaround, just have the site pop up a message and fail when it encounters the incognito browsers.

@Kyle-Falconer
Copy link

making this "small" to represent the band-aid fix of just notifying the user that we don't support incognito or private mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants