Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Price range not changing with props #1613

Open
CHFernandes opened this issue Jan 18, 2023 · 2 comments
Open

Price range not changing with props #1613

CHFernandes opened this issue Jan 18, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@CHFernandes
Copy link

Describe the bug
When changing the components min and/or max props, the change isn't reflected on the slider component

Expected behavior
PriceRange component to be reactive with the changes in its props

Current behavior
PriceRange component isn't updated when its props are changed

Steps to reproduce

  • Select a range
  • Change a value in the min or max prop (cleaning the filter for example)

Possible Solution
Make the component reactive to its props

Workspace
workspace with the bug behavior.

Additional context

Video demonstrating the bug:
https://user-images.githubusercontent.com/20386403/213175397-77091657-1cbf-4a63-89d4-a234745c8a42.mp4

@CHFernandes CHFernandes added the bug Something isn't working label Jan 18, 2023
@emersonlaurentino
Copy link
Member

@CHFernandes thanks for report, what's the @faststore/ui version?

@CHFernandes
Copy link
Author

@emersonlaurentino it is: 1.11.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants