Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated package.json dependencies in root and react folders #483

Open
ericreis opened this issue Jan 3, 2019 · 0 comments
Open

Duplicated package.json dependencies in root and react folders #483

ericreis opened this issue Jan 3, 2019 · 0 comments

Comments

@ericreis
Copy link
Contributor

ericreis commented Jan 3, 2019

Describe the bug
We currently have two package.json in the Styleguide project. One is for the npm publish (the one in the root folder) and one for the VTEX IO publish (the one in the react folder). This forces us to maintain the source of truth for the dependencies, what could very possibly lead to an error (as seen in #458)

Expected behavior
Only declare depencies once and maintain only one package.json.
@ericreis ericreis changed the title Duplicated package.json dependencies in root and react folders Duplicated package.json dependencies in root and react folders Jan 3, 2019
@kevinch kevinch mentioned this issue Dec 11, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ericreis