Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.3.2 releases #535

Merged
merged 2 commits into from
Oct 29, 2018
Merged

2.3.2 releases #535

merged 2 commits into from
Oct 29, 2018

Conversation

zoul0813
Copy link
Member

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Releases v2.3.2

  • Export dist (9912b5e)
  • Fix deep property path not working (fb02f26)
  • Fix fieldSubmit not calling validate method (c82c44b)
  • Fix Rawgit shut down (34e08a6)
  • docs: replace duplicated 2.3.0 with 2.3.1 (69bbfce)
  • feat(fields): add required attribute to checkbox component (2b3c7e5)
  • feat(fields): add required attribute to radios component (8d04252)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling 14eb52a on zoul0813:feature/v2.3.2 into d69e0af on vue-generators:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.916% when pulling 14eb52a on zoul0813:feature/v2.3.2 into d69e0af on vue-generators:master.

@coveralls
Copy link

coveralls commented Oct 22, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 89.916% when pulling da32bde on zoul0813:feature/v2.3.2 into d69e0af on vue-generators:master.

@zoul0813
Copy link
Member Author

@lionel-bijaoui you good with this?

@zoul0813
Copy link
Member Author

Pretty sure Deep Property Paths PR was backwards - we should be passing paths: true, collections: true, and all the other options should be disabled ... we also don't need to specify the other options as they are disabled by default. Pushing an update to this PR to fix this.

Ref: #526

@zoul0813 zoul0813 mentioned this pull request Oct 29, 2018
Closed
@zoul0813 zoul0813 merged commit a484031 into vue-generators:master Oct 29, 2018
@zoul0813 zoul0813 deleted the feature/v2.3.2 branch October 29, 2018 13:16
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this pull request Oct 29, 2018
@zoul0813
Merge branch 'master-origin' into develop
fa0a2ff 
* master-origin:
  vue-generators#535, vue-generators#526 - reversed "deep property path" fix
zoul0813 added a commit to zoul0813/vue-form-generator that referenced this pull request Oct 29, 2018
@zoul0813
Merge branch 'master-origin'
d81bf48 
* master-origin:
  vue-generators#535, vue-generators#526 - reversed "deep property path" fix
  2.3.2 releases
  Fix Rawgit shut down - Change link to cdnjs
  Export dist
  Fix deep property path not working - Deactivate `paths` option in 'lodash-webpack-plugin'
  docs: replace duplicated 2.3.0 with 2.3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qkdreyer qkdreyer qkdreyer approved these changes

@lionel-bijaoui lionel-bijaoui Awaiting requested review from lionel-bijaoui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zoul0813 @coveralls @qkdreyer