Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: time-picker bug #1176

Merged

Conversation

zkwolf
Copy link
Member

@zkwolf zkwolf commented Sep 10, 2019

当使用backspace删除所有字符后,输入第一个字符控制台报错,并无字符显示

问题在于尝试在子组件改变prop showStr,但是并没有发现这个showStr实际带来了什么作用,目前方案是直接删除了,按照例子测试了一下,暂时没有发现副作用

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.
    time-picker bug when use backspace to clear input #1173

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

当使用backspace删除所有字符后,输入第一个字符控制台报错,并无字符显示
@netlify
Copy link

netlify bot commented Sep 10, 2019

Deploy preview for ant-desing-vue processing.

Building with commit f566b31

https://app.netlify.com/sites/ant-desing-vue/deploys/5d774deec52fdb0008b935e1

@codecov
Copy link

codecov bot commented Sep 10, 2019

Codecov Report

Merging #1176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1176   +/-   ##
======================================
  Coverage    87.1%   87.1%           
======================================
  Files         146     146           
  Lines        4847    4847           
  Branches     1453    1453           
======================================
  Hits         4222    4222           
  Misses        558     558           
  Partials       67      67

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9107da...f566b31. Read the comment docs.

@tangjinzhou tangjinzhou merged commit c897d32 into vueComponent:master Sep 29, 2019
@zkwolf zkwolf deleted the fix-timepicker-backspace-delete-bug branch September 29, 2019 10:18
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants