Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add noscript tags for fallback content #43

Merged
merged 1 commit into from
Jul 8, 2017
Merged

Add noscript tags for fallback content #43

merged 1 commit into from
Jul 8, 2017

Conversation

DanielPintilei
Copy link
Contributor

The fallback message should be seen only when JavaScript fails to load. Currently, if the app loads on a slow network, it is displayed. I added the tags outside the root element, as seen in the create-react-app template.

@maxmilton
Copy link

maxmilton commented Jun 19, 2017

If we're going to do something like that, I'd prefer we have a better default message:

<noscript>
  For full functionality of this site it is necessary to enable JavaScript.
  Here are the <a href="http://www.enable-javascript.com/" target="_blank" rel="noopener">instructions how to enable JavaScript in your web browser</a>.
</noscript>

Of course it's up to the developer to set things up, but hey, may as well provide sane defaults.

@addyosmani addyosmani self-assigned this Jun 24, 2017
@addyosmani addyosmani merged commit 6d57c87 into vuejs-templates:master Jul 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants