minify service worker script before html inlining (#59) #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubhav7495
force-pushed
the
inline-sw-minify
branch
from
de50b6a
to
6432e80
Compare
anubhav7495
force-pushed
the
inline-sw-minify
branch
from
6432e80
to
990f1ea
Compare
|
@addyosmani Can you please take a look at this? |
addyosmani
approved these changes
Aug 4, 2017
|
@anubhav7495 Btw, just in case you might be interested in helping out with this repo too I've added you as a collaborator to it :) |
Gomah
reviewed
Aug 4, 2017
| @@ -10,6 +10,7 @@ var HtmlWebpackPlugin = require('html-webpack-plugin') | |||
| var ExtractTextPlugin = require('extract-text-webpack-plugin') | |||
| var OptimizeCSSPlugin = require('optimize-css-assets-webpack-plugin') | |||
| var SWPrecacheWebpackPlugin = require('sw-precache-webpack-plugin') | |||
| var loadMinified = require('./load-minfied') | |||
There was a problem hiding this comment.
Thanks. I will push a fix immediately.
|
@addyosmani Thanks. I have merged this PR because |
|
Cheers, @anubhav7495! |
frandiox
pushed a commit
to OnsenUI/vue-pwa-webpack
that referenced
this pull request
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the solution to minify the
service-worker-prod.jsbefore inlining in index.html.The approach works for me in production here: hnpwa-vue
Requesting reviews.
Thanks.