Video audio loader #765

Ffloriel · 2017-06-25T22:53:44Z

audio and video tag

nickmessing · 2017-06-25T23:07:54Z

.gitignore

@@ -1,3 +1,4 @@
 node_modules
 .DS_Store
 docs/_book
+.vscode/


This should not be a part of project's .gitignore because it has nothing to do with actual project. If vscode is your main code editor you should add it to your global .gitignore instead.

nickmessing · 2017-06-25T23:21:14Z

.gitignore

@@ -1,3 +1,3 @@
 node_modules
 .DS_Store
-docs/_book
+docs/_book


👍 but can you add \n back please? 😄

Ffloriel · 2017-06-25T23:23:04Z

done. sorry about that

nickmessing

👍

nickmessing · 2017-06-25T23:25:16Z

LGTM, you can ask some maintainers like @LinusBorg or @posva for review.

nickmessing · 2017-06-25T23:27:46Z

template/build/webpack.base.conf.js

@@ -56,6 +56,13 @@ module.exports = {
        options: {
          limit: 10000,
          name: utils.assetsPath('img/[name].[hash:7].[ext]')
+        },


Check this file again, looks like you missed a closing bracket here after options, now it is:

{ test: /\.(png|jpe?g|gif|svg)(\?.*)?$/, loader: 'url-loader', options: { limit: 10000, name: utils.assetsPath('img/[name].[hash:7].[ext]') }, }, // <-- Missed this { test: /\.(mp4|webm|ogg|mp3|wav|flac|aac)(\?.*)?$/, loader: 'url-loader', options: { limit: 10000, name: utils.assetsPath('media/[name].[hash:7].[ext]') } },

posva

Thanks for the PR!

posva · 2017-06-26T17:54:48Z

template/build/vue-loader.conf.js

@@ -8,5 +8,9 @@ module.exports = {
      ? config.build.productionSourceMap
      : config.dev.cssSourceMap,
    extract: isProduction
-  })
+  }),
+  transformToRequire: {


Can you keep it 2 spaces and add the default values as well: { img: 'src', image: 'xlink:href' }

Ffloriel · 2017-07-12T20:52:51Z

@nickmessing is there something else that needs to be changed?

nickmessing · 2017-07-12T21:47:48Z

@Ffloriel, no, you're in @LinusBorg's hands atm 😏

LinusBorg · 2017-07-13T09:20:12Z

Thanks!

* babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753) They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')` * build: Configure targets.browser for babel-preset-env (vuejs-templates#763) * Remove inconsistent spacing (vuejs-templates#754) * feat(gitignore): include common editor directories (vuejs-templates#774) * feat(gitignore): include common editor directories add common editor files and directories to .gitignore closes vuejs-templates#772 * feat(gitignore): remove .vscode directory remove .vscode directory from .gitignore * Video audio loader (vuejs-templates#765) * gitignore vscode * media loader audio and video tag * Remove vscode gitignore * Add \n back * fix missing closing bracket * add default values (img, image) * Upgrade vue-router to v2.6.0 (vuejs-templates#777) * Fix console error (vuejs-templates#784) Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING` * Fix proxy example (fix vuejs-templates#780) the glob pattern was too narrow, woudl not catch subpaths. * Fix autoprefixer explanation (vuejs-templates#798) The parameter to set in package.json is named "browserslist". * chore: Bump dev dependencies for template (vuejs-templates#790) * fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778) * Move Chat: Gitter -> Discord (vuejs-templates#869) * Remove unnecessary space and comma (vuejs-templates#866) * load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864) * Return exit code 1 when npm run build fails (vuejs-templates#854) * fix standard eslint config link (vuejs-templates#834) * fix ci build faild (vuejs-templates#857) * Removing Vue.config.debug usage from documentation (vuejs-templates#871) * Removing Vue.config.debug usage from documentation It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed * Update env.md * fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876) * bump vue & vue-router dependencies * Specify the address to listen on (vuejs-templates#759) Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo. * add HashedModuleIdsPlugin when build (vuejs-templates#870) * Add support for linked modules (vuejs-templates#688) * chore(package): rm unused lolex dependency(dev) (vuejs-templates#803) * fix vuejs-templates#877 * Revert vuejs-templates#688, fix vuejs-templates#879 We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879 * revert: vuejs-templates#759 That's actually not a good idea when you e.g. want to access the dev server from your mobile. * - Re-added check for router - Modified eslint file to use standard and have M be a global

Beltrw mods * babel should keep code comments. (fix vuejs-templates#730) (vuejs-templates#753) They are necessary for webpacks "magic comments" to work, e.g. with `import(/* webpackChunkName: "chunk1" */ './component.vue')` * build: Configure targets.browser for babel-preset-env (vuejs-templates#763) * Remove inconsistent spacing (vuejs-templates#754) * feat(gitignore): include common editor directories (vuejs-templates#774) * feat(gitignore): include common editor directories add common editor files and directories to .gitignore closes vuejs-templates#772 * feat(gitignore): remove .vscode directory remove .vscode directory from .gitignore * Video audio loader (vuejs-templates#765) * gitignore vscode * media loader audio and video tag * Remove vscode gitignore * Add \n back * fix missing closing bracket * add default values (img, image) * Upgrade vue-router to v2.6.0 (vuejs-templates#777) * Fix console error (vuejs-templates#784) Fix console error`Failed to load resource: net::ERR_INCOMPLETE_CHUNKED_ENCODING` * Fix proxy example (fix vuejs-templates#780) the glob pattern was too narrow, woudl not catch subpaths. * Fix autoprefixer explanation (vuejs-templates#798) The parameter to set in package.json is named "browserslist". * chore: Bump dev dependencies for template (vuejs-templates#790) * fix: Use false to disable webpack-hot-middleware log (vuejs-templates#778) * Move Chat: Gitter -> Discord (vuejs-templates#869) * Remove unnecessary space and comma (vuejs-templates#866) * load webpack.prod.conf when NODE_ENV=production (vuejs-templates#864) * Return exit code 1 when npm run build fails (vuejs-templates#854) * fix standard eslint config link (vuejs-templates#834) * fix ci build faild (vuejs-templates#857) * Removing Vue.config.debug usage from documentation (vuejs-templates#871) * Removing Vue.config.debug usage from documentation It has been removed; https://vuejs.org/v2/guide/migration.html#Vue-config-debug-removed * Update env.md * fixed vue-router dependency(need vue-loader@^13.0.0) (vuejs-templates#876) * bump vue & vue-router dependencies * Specify the address to listen on (vuejs-templates#759) Currently, this causes the dev server to listen on all addresses by default, which is not the intended behavior, imo. * add HashedModuleIdsPlugin when build (vuejs-templates#870) * Add support for linked modules (vuejs-templates#688) * chore(package): rm unused lolex dependency(dev) (vuejs-templates#803) * fix vuejs-templates#877 * Revert vuejs-templates#688, fix vuejs-templates#879 We have to investigate how we can get vuejs-templates#688 work without the error reported in vuejs-templates#879 * revert: vuejs-templates#759 That's actually not a good idea when you e.g. want to access the dev server from your mobile. * - Re-added check for router - Modified eslint file to use standard and have M be a global Approved-by: Jason Grubb <grubbjt@appstate.edu>

Ffloriel added 2 commits June 25, 2017 23:50

gitignore vscode

4bbcaed

media loader

b39d4a0

audio and video tag

nickmessing suggested changes Jun 25, 2017

View reviewed changes

Remove vscode gitignore

19dc6c1

nickmessing reviewed Jun 25, 2017

View reviewed changes

.gitignore Outdated

@@ -1,3 +1,3 @@

node_modules

.DS_Store

docs/_book

docs/_book

Copy link

nickmessing Jun 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 but can you add \n back please? 😄

Add \n back

b6e73ac

nickmessing approved these changes Jun 25, 2017

View reviewed changes

nickmessing suggested changes Jun 25, 2017

View reviewed changes

fix missing closing bracket

8438455

posva suggested changes Jun 26, 2017

View reviewed changes

add default values (img, image)

57ac535

posva approved these changes Jun 26, 2017

View reviewed changes

LinusBorg approved these changes Jul 12, 2017

View reviewed changes

LinusBorg self-assigned this Jul 12, 2017

nickmessing approved these changes Jul 12, 2017

View reviewed changes

LinusBorg merged commit 9992f5a into vuejs-templates:master Jul 13, 2017

Ffloriel mentioned this pull request Jul 15, 2017

video audio loader vuejs-templates/pwa#57

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Video audio loader #765

Video audio loader #765

Ffloriel commented Jun 25, 2017

nickmessing Jun 25, 2017

nickmessing Jun 25, 2017

Ffloriel commented Jun 25, 2017

nickmessing left a comment

nickmessing commented Jun 25, 2017

nickmessing Jun 25, 2017 •

edited

Loading

posva left a comment

posva Jun 26, 2017

Ffloriel commented Jul 12, 2017

nickmessing commented Jul 12, 2017

LinusBorg commented Jul 13, 2017

Video audio loader #765

Video audio loader #765

Conversation

Ffloriel commented Jun 25, 2017

nickmessing Jun 25, 2017

Choose a reason for hiding this comment

nickmessing Jun 25, 2017

Choose a reason for hiding this comment

Ffloriel commented Jun 25, 2017

nickmessing left a comment

Choose a reason for hiding this comment

nickmessing commented Jun 25, 2017

nickmessing Jun 25, 2017 • edited Loading

Choose a reason for hiding this comment

posva left a comment

Choose a reason for hiding this comment

posva Jun 26, 2017

Choose a reason for hiding this comment

Ffloriel commented Jul 12, 2017

nickmessing commented Jul 12, 2017

LinusBorg commented Jul 13, 2017

nickmessing Jun 25, 2017 •

edited

Loading