fix(runtime-core): error when key is Symbol.unscopable

vuejs · Dec 29, 2020 · bddc3c0 · bddc3c0
1 parent e5a5a2c
commit bddc3c0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/packages/runtime-core/__tests__/componentProxy.spec.ts b/packages/runtime-core/__tests__/componentProxy.spec.ts
@@ -240,6 +240,6 @@ describe('component: proxy', () => {
       `Property ${JSON.stringify(
         Symbol.unscopables
       )} was accessed during render ` + `but is not defined on instance.`
-    ).toHaveBeenWarned()
+    ).not.toHaveBeenWarned()
   })
 })
diff --git a/packages/runtime-core/src/componentPublicInstance.ts b/packages/runtime-core/src/componentPublicInstance.ts
@@ -241,7 +241,7 @@ export interface ComponentRenderContext {
 }
 
 export const PublicInstanceProxyHandlers: ProxyHandler<any> = {
-  get({ _: instance }: ComponentRenderContext, key: string) {
+  get({ _: instance }: ComponentRenderContext, keyOrSymbol: string | symbol) {
     const {
       ctx,
       setupState,
@@ -251,12 +251,18 @@ export const PublicInstanceProxyHandlers: ProxyHandler<any> = {
       type,
       appContext
     } = instance
+    const key = keyOrSymbol as string
 
     // let @vue/reactivity know it should never observe Vue public instances.
     if (key === ReactiveFlags.SKIP) {
       return true
     }
 
+    // this seems to come from the `with(_ctx) {}` used in render functions
+    if (keyOrSymbol === Symbol.unscopables) {
+      return undefined
+    }
+
     // for internal formatters to know that this is a Vue instance
     if (__DEV__ && key === '__isVue') {
       return true