Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After render fail "warn" cause "InternalError: too much recursion" if one of props is PublicInstanceProxyHandlers #1091

Closed
wszerad opened this issue Apr 30, 2020 · 1 comment

Comments

@wszerad
Copy link

wszerad commented Apr 30, 2020

Version

3.0.0-beta.5

Reproduction link

https://jsfiddle.net/24hun8ay/2/

Steps to reproduce

just run code

What is expected?

Normal warninig: "can't access property "a", a.a is undefined"

What is actually happening?

We get: "InternalError: too much recursion"


  1. "warn" function uses "formatProp" to format warning output
  2. "formatProp" checks type of prop by looking for "_isRef" field
  3. prop is a PublicInstanceProxyHandlers so when target doesn't contain such field we get warn again, go to 1.
@wszerad wszerad changed the title During render error "warn" cause "InternalError: too much recursion" if one of props is PublicInstanceProxyHandlers After render fail "warn" cause "InternalError: too much recursion" if one of props is PublicInstanceProxyHandlers Apr 30, 2020
@ysj16
Copy link
Contributor

ysj16 commented May 1, 2020

The state will be covered by ref in setRef-L1930(I wonder the reason for that), and then will call warn in componentProxy recursively. @yyx990803

@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants