-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(runtime-dom): avoid unnecessary prop patch for checkbox #11657
Merged
yyx990803
merged 8 commits into
vuejs:main
from
Mini-ghost:fix/prevent-unnecessary-patch
Sep 3, 2024
Merged
fix(runtime-dom): avoid unnecessary prop patch for checkbox #11657
yyx990803
merged 8 commits into
vuejs:main
from
Mini-ghost:fix/prevent-unnecessary-patch
Sep 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size ReportBundles
Usages
|
@vue/compiler-core
@vue/compiler-dom
@vue/compiler-sfc
@vue/reactivity
@vue/runtime-core
@vue/compiler-ssr
@vue/runtime-dom
@vue/server-renderer
@vue/shared
vue
@vue/compat
commit: |
/ecosystem-ci run |
Could you please add a test case for this? |
📝 Ran ecosystem CI: Open
|
edison1105
added
ready to merge
The PR is ready to be merged.
scope: v-model
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
need test
The PR has missing test cases.
and removed
ready to merge
The PR is ready to be merged.
labels
Aug 19, 2024
@edison1105 No problem, but I need to take some time to figure out how to write the tests for this. I'll need to wait until I finish my work today, so it might take a bit of time. I sincerely apologize for the delay. |
Mini-ghost
force-pushed
the
fix/prevent-unnecessary-patch
branch
from
August 19, 2024 10:39
38ac570
to
217dafc
Compare
edison1105
added
ready to merge
The PR is ready to be merged.
and removed
need test
The PR has missing test cases.
labels
Aug 20, 2024
edison1105
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
🔨 p3-minor-bug
Priority 3: this fixes a bug, but is an edge case that only affects very specific usage.
ready to merge
The PR is ready to be merged.
scope: v-model
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve: #11647
When the
value
isnull
orundefined
, andel.type
ischeckbox
, thenewValue
should be set as'on'
instead of an empty string.I would be most grateful for any feedback on this approach. If there are any concerns or alternative suggestions, please do not hesitate to share them, and I will be more than happy to make the necessary adjustments.