fix(ssr): v-slot stop empty attribute producing syntax error #3326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, sort of wish I could call Ooh, there is |
LinusBorg
reviewed
Mar 9, 2021
LinusBorg
added
🍰 p2-nice-to-have
HcySunYang
suggested changes
Mar 12, 2021
| @@ -90,6 +90,11 @@ describe('ssr: components', () => { | |||
| `) | |||
| }) | |||
|
|
|||
| test('empty attribute should not produce syntax error', () => { | |||
| // previously this would produce syntax error `default: _withCtx((, _push, ...)` | |||
| expect(compile(`<foo v-slot="">foo</foo>`).code).not.toMatch(`(,`) | |||
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh I didn't see the comment above
HcySunYang
approved these changes
Mar 12, 2021
|
Bump? Also is there something that could be done so that acorn produces better output for the syntax error since it doesn't map to visible source? |
Previously the cjs build implicitly relies on hoisted versions of the deps, causing it to resolve to newer versions of estree-walker when present. fix vuejs#6602
Co-authored-by: pengbo43 <pengbo43@jd.com> Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
Co-authored-by: webfansplz <>
…6812) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
…ot affect block tracking (vuejs#5670) fix vuejs#5657
…en prod and dev (vuejs#6714) fix vuejs#6697
…nitial values (fix: vuejs#5032) (vuejs#5033)
… types (fix: vuejs#2855) (vuejs#5458) Co-authored-by: Carlos Rodrigues <carlos@hypermob.co.uk>
…ejs#6810) Co-authored-by: Anthony Fu <anthonyfu117@hotmail.com>
…ring props normalization (close: vuejs#6915) (vuejs#6916)
|
Sorry for letting this hang for so long - somehow GitHub seems to fail to recognize updates in your branch even after I resolved the conflicts, so I had to manually land the changes in 09bb3e9. Thanks again! |
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
…mpty attr (vuejs#3326) squashed from fix by @tjk
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
…mpty attr (vuejs#3326) squashed from fix by @tjk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently produces an SSR render function with a syntax error (no first param):
The fix is probably not right but don't know internals enough to know where it should be fixed or how this should be handled better. As I left a comment, if this should error instead of just work... it probably still requires changes because currently you just end up with a stack trace for compiled source code which you cannot see, for example:
SyntaxError: Unexpected token (108:22) at Object.pp$4.raise (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:37624:13) at Object.pp.unexpected (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:35315:8) at Object.pp$3.parseExprAtom (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:37022:10) at Object.pp$3.parseExprSubscripts (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36825:19) at Object.pp$3.parseMaybeUnary (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36802:17) at Object.parseMaybeUnary (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:45345:29) at Object.pp$3.parseExprOps (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36737:19) at Object.pp$3.parseMaybeConditional (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36720:19) at Object.pp$3.parseMaybeAssign (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36688:19) at Object.pp$3.parseParenAndDistinguishExpression (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:37118:28) at Object.pp$3.parseExprAtom (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36982:41) at Object.pp$3.parseExprSubscripts (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36825:19) at Object.pp$3.parseMaybeUnary (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36802:17) at Object.parseMaybeUnary (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:45345:29) at Object.pp$3.parseExprOps (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36737:19) at Object.pp$3.parseMaybeConditional (/Users/tj/src/github.com/vitejs/vite/packages/vite/dist/node/chunks/dep-ed571b05.js:36720:19) { pos: 5439, loc: Position { line: 108, column: 22 }, raisedAt: 5440 }