New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(reactivity): fix unit test case that don't make sense #3884

Closed

originalix wants to merge 2 commits into vuejs:master from originalix:master

originalix commented Jun 4, 2021 •

edited

Loading

This proto case declares the prototype variable but is never used. And the otherObj variable has nothing to do with this use case.

__proto__ is one of the non trackable keys, so it should return original.

I use Object.create({}) instead {} that can fix ts error and remove @ts-ignore.

originalix added 2 commits

June 4, 2021 09:24


          test(reactivity): fix do not make sense unit test case

0e49d78


          test(reactivity): fix __proto__ undefined

20466bd

Member

yyx990803 commented Jun 8, 2021

As the comment suggests, it is intentionally testing the side effect of reading __proto__. See #1107

yyx990803 closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet