fix(normalizaProp): support css variable as number #6636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusBorg
approved these changes
Sep 17, 2022
LinusBorg
added
ready to merge
yyx990803
previously requested changes
Sep 27, 2022
packages/shared/src/domAttrConfig.ts
Outdated
| @@ -63,6 +63,7 @@ export const isNoUnitNumericStyleProp = /*#__PURE__*/ makeMap( | |||
| `grid-row,grid-row-end,grid-row-span,grid-row-start,grid-column,` + | |||
| `grid-column-end,grid-column-span,grid-column-start,font-weight,line-clamp,` + | |||
| `line-height,opacity,order,orphans,tab-size,widows,z-index,zoom,` + | |||
| `-webkit-line-clamp,` + | |||
There was a problem hiding this comment.
Only adding this doesn't make sense, since every property here are non-prefixed standard properties. There are most likely other prefixed versions of some other properties that can be treated as numbers, and it is impractical for us to support all of them.
I think just supporting custom properties is good enough in this PR. Whether we want to support vendor-prefixed properties is a separate problem.
antfu
approved these changes
Oct 3, 2022
edison1105
approved these changes
Nov 6, 2022
sxzz
approved these changes
Nov 6, 2022
|
I decided to remove the unit check altogether since due to vendor prefixes and custom properties, the check seems to be unnecessarily strict for little value (for the end user, the browser render result will be the same). |
chrislone
pushed a commit
to chrislone/core
that referenced
this pull request
Feb 4, 2023
Previously this prevented custom properties and vendor-prefixed properties to be rendered correctly. fix vuejs#6625
zhangzhonghe
pushed a commit
to zhangzhonghe/core
that referenced
this pull request
Apr 12, 2023
Previously this prevented custom properties and vendor-prefixed properties to be rendered correctly. fix vuejs#6625
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #6625