-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support v-model
for <details>
and <dialog>
#8048
Open
antfu
wants to merge
3
commits into
minor
Choose a base branch
from
feat/v-model-details-dialog
base: minor
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 8, 2023
yyx990803
reviewed
Apr 10, 2023
Looks like this is lacking runtime behavior tests in https://github.com/vuejs/core/blob/main/packages/runtime-dom/__tests__/directives/vModel.spec.ts |
Test added, |
4 tasks
sxzz
approved these changes
Aug 12, 2023
sxzz
force-pushed
the
feat/v-model-details-dialog
branch
from
August 21, 2023 08:13
3e2efe0
to
eb5ca19
Compare
Size ReportBundles
Usages
|
Closed
sxzz
force-pushed
the
minor
branch
2 times, most recently
from
September 22, 2023 08:11
dc30885
to
be91d43
Compare
sxzz
force-pushed
the
minor
branch
4 times, most recently
from
October 20, 2023 09:35
5d93a55
to
06ad749
Compare
Hello! I didn't see this particular feature mentioned in 3.4 release candidate. Is this still planned? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v-model
on<details>
and<dialog>
rfcs#496v-model
fordialog
anddetails
docs#2315