Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump to Vue 3.0.0-beta.15 #141

Merged
merged 2 commits into from
Jun 25, 2020

Conversation

cexbrayat
Copy link
Member

No description provided.

@cexbrayat
Copy link
Member Author

@pikax If you don't mind, I'd like your opinion on the failing dts test:

// no data provided
expectError(
  mount(AppWithDefine, {
    data() {
      return {
        myVal: 1
      }
    }
  })
)

is not throwing error with beta.15 whereas it was when you introduced it. Is there something we need to change in our mount signatures or is it normal that this does not fail anymore with mixins and entends?

@lmiller1990
Copy link
Member

This is just a types error that is breaking things yeah? What changed in Vue core 🤔

@cexbrayat
Copy link
Member Author

cexbrayat commented Jun 15, 2020

@lmiller1990 Nothing major, but it looks like we lost a bit of inference. Not a big deal, I just want to make sure we're not missing something ;)

@cexbrayat
Copy link
Member Author

@pikax Thanks for your help!

@lmiller1990 If that's OK with you, we can merge and I'll take care of removing the TODO when vuejs/core#1361 is merged and released (I hope it will make it in beta.16). Or we can wait for beta.16, as you wish

@lmiller1990
Copy link
Member

Seems like it's fine to wait - this PR isn't blocking anything.

Thanks for this!

@lmiller1990
Copy link
Member

Looks like we are good to merge yeah @cexbrayat ?

@lmiller1990 lmiller1990 merged commit 9468fc1 into vuejs:master Jun 25, 2020
@cexbrayat
Copy link
Member Author

👍 I'll remove the TODO when beta.16 will be out

@cexbrayat cexbrayat deleted the chore/vue-beta-15 branch June 25, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants