fix: vm should be the vm of the tested component #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep I think I fixed this one in the |
tests/vm.spec.ts
Outdated
| setup() { | ||
| const msg = 'hello' | ||
| const isEnabled = ref(true) | ||
| const toggle = () => (isEnabled.value = !isEnabled.value) |
There was a problem hiding this comment.
Toggle is not necessary here.
There was a problem hiding this comment.
👍 Removed (it was a leftover of a more in-depth test for #64 )
lmiller1990
approved these changes
Apr 14, 2020
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently returns the vm of the parent element.
With this commit, it now returns the vm of the tested element.
The test showcases the correct behavior: you can reproduce the issue by adding the test to the master banch. It will fail as it returns the vm of the parent which has no msg, isEnabled fields and toggle function.