feat: properly type mount with props #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 17, 2020
|
Cool, will wait for beta 2. I am very excited for this feature. |
lmiller1990
reviewed
Apr 17, 2020
cexbrayat
force-pushed
the
fix/props-type
branch
from
31f6101
to
8533bbe
Compare
|
Will leave this open until beta-2, which fixes a few things. Looks good otherwise |
lmiller1990
approved these changes
Apr 18, 2020
This offers proper typings for the props given in the mounting options.
cexbrayat
force-pushed
the
fix/props-type
branch
from
8533bbe
to
ef173f7
Compare
|
@lmiller1990 I rebased on top of master, we should be good to merge 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This offers proper typings for the props given in the mounting options.
For example
mount(defineComponent({ props: { a: string}}), {props: {a: 2}})fails to compile.Only issue with this PR is that we need
ExtractPropTypesto be public to properly type check the casemount({ props: { a: String }}, { props: {a: 2}}).I'll open a discussion on vue-next and link back here (see vuejs/core#983).
Update: Evan merged it, so we'll be able to merge this one when beta.2 is released.
On top of #73