Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seemingly arbitrary code suggestions using Emacs + LSP. #2574

Closed
4 tasks done
mikejholly opened this issue Dec 17, 2020 · 2 comments · Fixed by #2635
Closed
4 tasks done

Seemingly arbitrary code suggestions using Emacs + LSP. #2574

mikejholly opened this issue Dec 17, 2020 · 2 comments · Fixed by #2635
Labels
bug lsp:general LSP integration for use in LSP clients

Comments

@mikejholly
Copy link

mikejholly commented Dec 17, 2020

  • I have searched through existing issues
  • I have read through docs
  • I have read FAQ
  • I have tried restarting VS Code or running Vetur: Restart VLS

Info

  • Platform: Linux
  • Vetur version: 0.6.4
  • VS Code version: N/A

Problem

Seemingly arbitrary suggestions using Emacs + LSP.

When I open a .vue file using web-mode and lsp-mode with vls support, I see suggestions that don't seem to be accurate or relevant to the actual code. Actual errors seem to be working fine (underlined with correct messages).

The project was generated using the Vue CLI.

Apologies if this is the wrong place to report the issue. Perhaps you can point me in the right direction, if so.

image

Reproducible Case

Note: Veturpack doesn't seem relevant here since the problem is related to Emacs.

  1. Check out https://github.com/mikejholly/vetur-issue.
  2. Open in Emacs 28. Start web-mode & LSP (latest).
  3. Navigate cursor to <script> tags.
  4. Suggestions should appear.
@yoyo930021 yoyo930021 added bug lsp:general LSP integration for use in LSP clients labels Dec 18, 2020
@dirodriguezm
Copy link

How did you solve this ?

@yoyo930021
Copy link
Member

How did you solve this ?

This line

disabled: action.notApplicableReason ? { reason: action.notApplicableReason } : undefined,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug lsp:general LSP integration for use in LSP clients
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants