add --log-level option to vti diagnostics #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukukotani
changed the title
yukukotani
force-pushed
the
vti-error-only
branch
from
bdd032c to
ef115c8
Compare
yukukotani
force-pushed
the
vti-error-only
branch
from
ef115c8 to
2d7f019
Compare
yoyo930021
requested changes
Mar 8, 2021
vti/src/cli.ts
Outdated
| ) | ||
| .action(async (workspace, options) => { | ||
| const logLevelOption: unknown = options.logLevel; | ||
| if ( |
There was a problem hiding this comment.
Why don't use logLevels from import?
There was a problem hiding this comment.
@yoyo930021 Because logLevels type is readonly ["ERROR", "WARN", "INFO", "HINT"], we cannot call logLevels.includes with unknown value.
related issue: microsoft/TypeScript#26255
There was a problem hiding this comment.
We can use as keyword or is function to force it.
Repeated text will cause follow-up maintenance problems.
There was a problem hiding this comment.
@yoyo930021 ok. I've removed repeated text. e905cb2
yukukotani
force-pushed
the
vti-error-only
branch
from
e4b3788 to
e33df10
Compare
yoyo930021
approved these changes
Mar 8, 2021
This was referenced Mar 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2723.
vti diagnostics --log-level ERRORto ignore warns and print only errors.