fix(electron): chunk message data #2053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added chunking to bridge
send
function, in the electron shell backend, to prevent crash when sending very large payload.Added chunk function, in utils, based on Andrei R answer on stackoverflow.
Additional context
Socket.io's size limit is 1 mb. When sending a payload larger than that, the socket connection would hang up on it's own and the devtools would be disconnected.
This PR could potentially fix many crashing issue when working with large projects. Some related issues are:
However, this fix is only applied on the standalone electron app. This is why I am not referencing this PR as a direct fix for those issues.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).