Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'css-loader' uses in documentation #1785

Closed
joaohaas opened this issue Jan 5, 2021 · 3 comments
Closed

Fix 'css-loader' uses in documentation #1785

joaohaas opened this issue Jan 5, 2021 · 3 comments

Comments

@joaohaas
Copy link

joaohaas commented Jan 5, 2021

What problem does this feature solve?

Not exactly a feature request, but also not a bug.

Currently <style> tags do not work if following any of the documentation examples. This is due to the fact that vue-style-loader does not support css-loader 4.x.x or 5.x.x (vuejs/vue-style-loader#50, vuejs/vue-style-loader#46).

What does the proposed API look like?

It seems it can easily be fixed by disabling esModule:

{
    loader: 'css-loader',
    options: {
        esModule: false
    }
}

I can open a PR to fix these issues, but I'm not sure if that's wanted, since it's a issue with vue-style-loader, and it adds a bit of complexity to new users. At the same time, the current examples are not working at all, and vue-style-loader repo's last commit was in 2018... so not sure if those issues are going to be fixed.

EDIT: We can also change the npm install ... lines to install css-loader@3, and add an explanation on why you need to use an older version.

@fredgan
Copy link

fredgan commented Jan 12, 2021

Sounds good. Why not open a PR to record it the docs. ^_^

@euoia
Copy link

euoia commented Jan 15, 2021

This also caught me out!

@haoqunjiang
Copy link
Member

ES module interop added in vue-style-loader 4.1.3. So I'm closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants