fix(runtime-dom): event handlers with modifiers should get all event arguments #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekosaur
force-pushed
the
fix/event-modifier-args
branch
from
9e8c3c2
to
7011bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Vue 3 behaviour: https://codepen.io/nekosaur/pen/dyYqgyZ
Regular event handler sends all arguments, but with modifier it only sends first one (event). This seems inconsistent.
Scenario is if one would like to enable the use of modifiers and short template syntax while sending custom event values.
See vuejs/vue#10867, vuejs/vue#10958, vuetifyjs/vuetify#9720