Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(compiler-core): add onContextCreated option to CodegenOptions #1672

Merged
merged 1 commit into from
Jul 21, 2020
Merged

feat(compiler-core): add onContextCreated option to CodegenOptions #1672

merged 1 commit into from
Jul 21, 2020

Conversation

znck
Copy link
Member

@znck znck commented Jul 21, 2020

I haven't added to onContextCreated to CodegenOptions to avoid circular dependency as it is defined in options.ts and CodegenContext is in codegen.ts.

@znck znck requested a review from yyx990803 July 21, 2020 17:57
@yyx990803
Copy link
Member

This will only allow use of it when calling generate in TS - is that intentional? (which I think is ok since this should be considered internal API)

@yyx990803 yyx990803 merged commit 615dccd into vuejs:master Jul 21, 2020
@znck
Copy link
Member Author

znck commented Jul 22, 2020

Yes, it was intentional.

@znck znck deleted the onContextCreated branch July 22, 2020 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyx990803 yyx990803 Awaiting requested review from yyx990803

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@znck @yyx990803