Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provide() overrides inject() with same key in the current instance if it appears early. #2400

Closed
07akioni opened this issue Oct 17, 2020 · 2 comments · Fixed by #2424
Closed

provide() overrides inject() with same key in the current instance if it appears early. #2400

07akioni opened this issue Oct 17, 2020 · 2 comments · Fixed by #2424

Comments

@07akioni
Copy link
Contributor

Version

3.0.1

Reproduction link

https://codesandbox.io/s/vue-provide-bug-i8iq9?file=/src/App.js

Steps to reproduce

follow the link

What is expected?

A Provide => A

What is actually happening?

A Provide
@07akioni
Copy link
Contributor Author

Although it works if I put provide after inject, I think it shouldn't work in this way.

@69hunter
Copy link
Contributor

I think for the provide/inject API, the component should not be able to self-inject it's own provide, regardless of the order of provide and inject in the setup function. As previously mentioned in #1818.

69hunter added a commit to 69hunter/vue-next that referenced this issue Oct 19, 2020
@69hunter
fix(runtime-core): prevent self-injection (vuejs#2400)
549a4b4
@69hunter 69hunter mentioned this issue Oct 19, 2020
Merged
yyx990803 pushed a commit that referenced this issue Oct 20, 2020
@69hunter
fix(runtime-core): prevent self-injection (#2424)
111d04f 
fix #2400
@huanggm huanggm mentioned this issue Jan 15, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(runtime-core): prevent self-injection (#2400) 69hunter/vue-next
2 participants
@69hunter @07akioni