Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transition group with multiple classes not working #638

Closed
ruslansteiger opened this issue Jan 19, 2020 · 1 comment · Fixed by #645
Closed

Transition group with multiple classes not working #638

ruslansteiger opened this issue Jan 19, 2020 · 1 comment · Fixed by #645
Assignees
@LinusBorg

Comments

@ruslansteiger
Copy link

ruslansteiger commented Jan 19, 2020 •
edited
Loading

Version

3.0.0-alpha.1

Reproduction link

https://github.com/SuddenlyRust/transition-group-with-multiple-classes

Steps to reproduce

npm run serve

Remove or add an item to the list.

What is expected?

Item is added or removed from the list with transition effects.

What is actually happening?

Following exception appears
DOMException: Failed to execute 'add' on 'DOMTokenList': The token provided ('duration-500 ease-out') contains HTML space characters, which are not valid in tokens.

image

It looks like multiple classes are not supported in the alpha version but in Vue 2 it is working.

See https://github.com/SuddenlyRust/transition-group-with-multiple-classes/blob/master/src/App.vue#L4
@LinusBorg
Copy link
Member

I think we should continue to support that. Will do a quick PR.

@LinusBorg LinusBorg self-assigned this Jan 19, 2020
yyyanghj pushed a commit to yyyanghj/vue-next that referenced this issue Jan 20, 2020
fix(transition): correct pass argument into classList api
160c607 
close vuejs#638
@yyyanghj yyyanghj mentioned this issue Jan 20, 2020
Merged
yyx990803 pushed a commit that referenced this issue Jan 20, 2020
@yyx990803
fix(transition): handle multiple transition classes (#638) (#645)
98d50d8 
fix #638
@jonaskuske jonaskuske mentioned this issue Jan 30, 2020
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LinusBorg LinusBorg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(transition): correct pass argument into classList api (#638) yyyanghj/vue-next
2 participants
@LinusBorg @ruslansteiger