fix(types): allow null/undefined in query params

fix #2605
vuejs · Feb 5, 2019 · ca30a75 · ca30a75
1 parent 658eee6
commit ca30a75
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/types/router.d.ts b/types/router.d.ts
@@ -108,7 +108,7 @@ export interface Location {
   name?: string;
   path?: string;
   hash?: string;
-  query?: Dictionary<string | string[]>;
+  query?: Dictionary<string | (string | null)[] | null | undefined>;
   params?: Dictionary<string>;
   append?: boolean;
   replace?: boolean;
@@ -118,7 +118,7 @@ export interface Route {
   path: string;
   name?: string;
   hash: string;
-  query: Dictionary<string | string[]>;
+  query: Dictionary<string | (string | null)[]>;
   params: Dictionary<string>;
   fullPath: string;
   matched: RouteRecord[];

diff --git a/types/test/index.ts b/types/test/index.ts
@@ -105,7 +105,7 @@ const route: Route = router.currentRoute;
 const path: string = route.path;
 const name: string | undefined = route.name;
 const hash: string = route.hash;
-const query: string | string[] = route.query["foo"];
+const query: string | (string | null)[] | null = route.query["foo"];
 const params: string = route.params["bar"];
 const fullPath: string = route.fullPath;
 const redirectedFrom: string | undefined = route.redirectedFrom;
@@ -149,6 +149,9 @@ router.push({
   },
   query: {
     bar: "bar",
+    empty: null,
+    removed: undefined,
+    withEmpty: ["1", null],
     foo: ["foo1", "foo2"]
   },
   hash: "hash"