Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scroll behavior: hash that starts with number #2163

Closed
yyx990803 opened this issue Apr 18, 2018 · 4 comments · Fixed by mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, tghelere/valorize-vidas#4, tghelere/DeliVuery#18 or tghelere/dailymages#2
Closed

Scroll behavior: hash that starts with number #2163

yyx990803 opened this issue Apr 18, 2018 · 4 comments · Fixed by mariazevedo88/hash-generator-js#5, noprotocol/Bubblicious#3, tghelere/valorize-vidas#4, tghelere/DeliVuery#18 or tghelere/dailymages#2
Labels
improvement

Comments

@yyx990803
Copy link
Member

ref: vuejs/vuepress#121

When the selector starts with /^#\d/, should use getElementById instead.
@karanisverma
Copy link

Hey @yyx990803 , I would like to work on this Issue. it would be great if you can point me toward right approach.

@posva
Copy link
Member

posva commented Nov 26, 2018

@karanisverma It's in src/history/base.js line 199

@karanisverma
Copy link

Thanks @posva :) looking into it!

@karanisverma
Copy link

Hi @posva, I have looked at the code base not really sure how this can be fixed 😂.. Moreover I am not able to reproduce this issue at my end.

@posva posva closed this as completed in 799ceca Jul 8, 2019
This was referenced Aug 29, 2019
Open
Open
Closed
Open
@tt9133github tt9133github mentioned this issue Sep 18, 2019
Open
This was referenced Sep 22, 2019
Merged
Open
Open
This was referenced Sep 30, 2019
Merged
Open
This was referenced Oct 26, 2019
Open
Open
Open
@snyk-bot snyk-bot mentioned this issue Dec 5, 2019
Open
This was referenced Jan 20, 2020
Merged
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this issue Jan 27, 2020
Closed
This was referenced Feb 5, 2020
Merged
Open
Merged
@tt9133github tt9133github mentioned this issue Feb 14, 2020
Open
@snyk-bot snyk-bot mentioned this issue Feb 25, 2020
Closed
This was referenced Mar 4, 2020
Open
Open
This was referenced Mar 24, 2020
Merged
Closed
@snyk-bot snyk-bot mentioned this issue Apr 3, 2020
Merged
This was referenced Apr 15, 2020
Open
Open
@veaba veaba mentioned this issue Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 mariazevedo88/hash-generator-js
[Snyk] Upgrade vue-router from 3.0.7 to 3.1.3 noprotocol/Bubblicious
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 tghelere/valorize-vidas
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/DeliVuery
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/dailymages
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.3 tghelere/vuestore
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.3 estafette/estafette-ci-web
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.4 santosomar/linux_kernel_cves
[Snyk] Upgrade vue-router from 3.0.2 to 3.1.6 OpenTMI/opentmi-default-gui
[Snyk] Upgrade vue-router from 3.0.1 to 3.1.6 LuisAlejandro/luisalejandro.github.io-legacy
3 participants
@yyx990803 @posva @karanisverma