-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make callback of next in beforeRouterEnter more consistent #2738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks! Could you add a test for this? An e2e test should do it. You could check that a string grows to a specific value (to check the order is right) but if you have a better idea, that's good too!
@posva , I will add a test for it. I intend to add the test in navigation guards, but I find that the test code in this file never execute because it just return when find use |
I see, I will take a look next week then and keep you posted. Thanks for #2749 BTW! |
As you said, it does fix #2761 too, I added a test for that. I will add another test for the other case too |
Thx. |
Hey @zrh122, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
Improve #2728. Make callback of
next
to be called as same order asbeforeRouterEnter
.