Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no warn if pathMatch is empty (fix #3072) #3081

Merged
merged 1 commit into from
Dec 30, 2019
Merged

Conversation

yinm
Copy link
Contributor

@yinm yinm commented Dec 26, 2019

Try to fix #3072
if pathMatch is empty, skip warning.

@yinm yinm marked this pull request as ready for review December 26, 2019 12:50
src/util/params.js Outdated Show resolved Hide resolved
@yinm yinm force-pushed the fix-pathMatch-warn branch from aac5049 to 590adbb Compare December 27, 2019 11:58
@@ -24,9 +24,8 @@ export function fillParams (

return filler(params, { pretty: true })
} catch (e) {
if (process.env.NODE_ENV !== 'production') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the if was necessary though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, I revert it

@yinm yinm force-pushed the fix-pathMatch-warn branch from 8a213d9 to 590adbb Compare December 27, 2019 23:04
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Named catch-all route warns if pathMatch is empty
2 participants