-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: also support passed ES Modules from css-loader
in addition to CommonJS format
#47
Conversation
I think it should be moved here: |
You're right, this is a much cleaner solution that addresses the problem at the root. Thank you @meowtec Retested and verified. |
Can we get this in? Currently, guides/tutorials for ground-up Webpack setup using the latest Personally wasted a lot of time thinking it was a SSR issue. I imagine many beginners might have been deterred because they couldn't get past this styling bug. Minimal bug reproduction here. |
any good news? |
This issue took me on my learning journey today 5+ hours before I found the relation to the css-loader version.. :/ |
@yyx990803 any updates? do you perhaps have other plans for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems anyone can approve PRs without having merging privileges
Thanks @privatenumber. That's confusing. Guess I'll wait for @yyx990803 |
@sodatea Thank you! 🙏🏽 |
releases https://github.com/vuejs/vue-style-loader/releases are not updated for longer time |
@nolimitdev on npm seems fine: https://www.npmjs.com/package/vue-style-loader |
@nolimitdev Updated. Thanks for the reminder! |
What kind of change does this PR introduce?
Fix for new default behavior of
css-loader
v4Did you add tests for your changes?
No, due to small change and backwards compatibility. Happy to add if required.
Summary
Due to
css-loader
using ES Modules as the new default in v4, this module breaks when upgradingcss-loader
to latest (see #46, #42). This patch addresses that problem.Does this PR introduce a breaking change?
No, tested to be backwards compatible.
Other information
Not sure what the future plans are for this module and whether it's still relevant when Vue 3 releases (I didn't see
vue-style-loader
listed as a dependency on vue3 bundles), so feel free to discard this patch if this module is to be phased out.Fixes #46, Fixes #42