-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set wrapper.vm if the element binds Vue instance #724
Conversation
Can you check in createWrapper if there is a componentInstance, and if there is return a wrapper using componentInstance?
|
Thank you for reviewing. |
If that works then I think you can remove the extra code in this PR? |
No, it is not. |
I think that the following code is not necessary if this change code exists. if (node.componentInstance) {
return new VueWrapper(node.componentInstance, options)
} |
Why is it necessary to get the instance from vm.$children? I thought we could keep the same logic for getting vnodes. Then we could check that if the vnode is for a component instance in the create-wrapper function. |
I misunderstood. |
I fixed it. |
This is related to #687.