bail out of event blocking for Adobe CEP bug (fix #10366) #10459
+17
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericdrobinson
changed the title
ericdrobinson
changed the title
|
One note: |
derrickb
reviewed
Sep 6, 2019
Some Adobe CEP environments have a broken Event.timeStamp implementation that breaks event blocking logic. The issue specifically affects host applications running on macOS with CEP version 9.3 and below. This workaround is OS-agnostic so as to maintain identical behavior across platforms. More details can be found in issue vuejs#10366. fix vuejs#10366
ericdrobinson
force-pushed
the
fix-adobe-cep-mouse-events
branch
from
58eb122 to
1911503
Compare
|
@derrickb Fixed! Thanks for catching that!! 😅 |
posva
reviewed
Sep 9, 2019
posva
reviewed
Sep 9, 2019
Improve type checking of the `__adobe_cep__` object. It shouldn't just be `undefined` but explicitly an object.
It is possible that extremely early versions of Adobe CEP did not have the `getCurrentApiVersion` function defined. In such cases, assume "CEP 9.3 or earlier".
|
@posva Fixes applied. Please let me know if there is anything further! |
13 tasks
|
For the record, the decision to assume that:
was correct. I just ran across this statement in the official CEP Cookbook:
Awesome. 💪 |
posva
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #10366
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
Some Adobe CEP environments have a broken
Event.timeStampimplementation that breaks event blocking logic. The issue specifically affects host applications running on macOS with CEP version 9.3 and below. This workaround is OS-agnostic so as to maintain identical behavior across platforms. More details can be found in issue #10366.