fix(compiler): event handler with modifiers swallowing arguments #10958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. This is kind of strange b/c I can successfully run the todomvc app using my build w/o issue. I'm not very familiar with nightwatch; perhaps someone with a better eye can help me debug this one. |
|
It's probably necessary to avoid the spread operator to support more browsers and use |
despreston
force-pushed
the
des/event-handlers-modifiers-args
branch
from
66c5a3c
to
07cfa51
Compare
…vuejs#10867) Pass full parent argument list to the event handler when there are event modifiers present.
despreston
force-pushed
the
des/event-handlers-modifiers-args
branch
from
07cfa51
to
3d31982
Compare
|
@posva Thanks again! |
posva
approved these changes
Dec 27, 2019
|
@posva Do you know if there's a plan to push this into production soon? I'm actually being bit by this in a project now. The workaround works but obviously I'd prefer the solution I helped fix 😝. |
posva
changed the title
posva
force-pushed
the
des/event-handlers-modifiers-args
branch
from
aff02d7
to
3d31982
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass full parent argument list to the event handler when there are event
modifiers present.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)Fix #10867