Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(events): rule of calling binded event handler (close #11014) #11031

Closed
wants to merge 1 commit into from
Closed

fix(events): rule of calling binded event handler (close #11014) #11031

wants to merge 1 commit into from

Conversation

rx-837
Copy link

@rx-837 rx-837 commented Jan 18, 2020

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The checkbox 'Refactor' is checked because of rules ordering was changed. The primary rule should have bigger priority than crutches.

@joaomlemos
Copy link

The fix looks good. Would be nice to have this merged 👍 !

@jo4santos
Copy link

👍

@toshi38
Copy link

toshi38 commented Oct 22, 2020

Have tested this fix, can confirm that it fixes our issue. Is there a chance of getting this merged so we don't need to have a patched version of Vue?

@s-tokutake
Copy link

is there any update on this? we suffer the same problem as this.

Copy link

@SuceV587 SuceV587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix qt env

@rx-837 rx-837 closed this by deleting the head repository Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants