Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

must emit AsyncMarkdownContentMounted #1022

Closed
bailnl opened this issue Nov 18, 2018 · 2 comments
Closed

must emit AsyncMarkdownContentMounted #1022

bailnl opened this issue Nov 18, 2018 · 2 comments

Comments

@bailnl
Copy link
Contributor

bailnl commented Nov 18, 2018

If you customize <script/>, you must write your own slotKey and $emit AsyncMarkdownContentMounted event

https://github.com/vuejs/vuepress/blob/master/packages/%40vuepress/markdown-loader/index.js#L110

If it doesn't trigger, it will report an error when switching pages.
destroy of undefined, this.$smoothScroll is undefined

image

Version

"vuepress": "^1.0.0-alpha.23",

@ulivz
Copy link
Member

ulivz commented Nov 18, 2018

Thanks for your report, but it's duplicate of #975, let's move here to continue.

FYI. for now do not write <script> at markdown file. (You can put them under a Vue component), we'll fix it before we reach beta stage.

@ulivz ulivz closed this as completed Nov 18, 2018
@ulivz
Copy link
Member

ulivz commented Dec 12, 2018

Fixed at ece2e1e and out at vuepress/1.0.0-alpha.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants