Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in local theme index.js should not be ignored and reported as "cannot resolve plugin ..." #1296

Closed
1 task done
shigma opened this issue Feb 15, 2019 · 1 comment · May be fixed by adamlaska/osmos-cosmos-sdk#5
Closed
1 task done
Labels
contribution welcome Contributions welcome has PR Has a related PR type: enhancement Request to enhance an existing feature type: feature request Request to add a new feature

Comments

@shigma
Copy link
Collaborator

shigma commented Feb 15, 2019

  • I confirm that this is a issue rather than a question.

Bug report

Version

1.0.0-alpha.36

Steps to reproduce

.vuepress
├─ config.js
├─ theme
   ├─ index.js
   ├─ and other files ...

Assuming that an error was encounted in index.js, vuepress will leave a message cannot resolve plugin .../.vuepress/theme. But this behavior is rather strange and may mislead user with an indication that the theme is not found. Also, I think errors in local theme index file should not be simply ignored.

What is expected?

  • stop the process like an error was encounted in the config.js, or
  • provide a better warning like an error was encounted in ......

What is actually happening?

cannot resolve plugin .../.vuepress/theme

Other relevant information

  • Your OS: N/A
  • Node.js version: N/A
  • Browser version: N/A
  • Is this a global or local install? N/A
  • Which package manager did you use for the install? N/A
@ulivz ulivz added type: feature request Request to add a new feature type: enhancement Request to enhance an existing feature labels Feb 19, 2019
@ulivz
Copy link
Member

ulivz commented Feb 19, 2019

The theme's configuration file themeEntryFile also supports all the plugin api so it'll be applied like a plugin, so this unfriendly log should also occur in the normal plugin.

We truly need to enhance the log, contribution welcome! and I trust your sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution welcome Contributions welcome has PR Has a related PR type: enhancement Request to enhance an existing feature type: feature request Request to add a new feature
Projects
None yet
2 participants