-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat($core): better layout check #1455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d94fe3f.
@shigma can you resolve the conflict please and it will be good for me |
flozero
added
complexity: medium
Medium complexity
effort: low
Around a day or less
status: core team assigned
Core team member assigned
topic: theme
Relates to VuePress theme
type: enhancement
Request to enhance an existing feature
version: 1.x
Relates to version 1 of VuePress
labels
Sep 5, 2019
maybe update the docs about it |
flozero
approved these changes
Sep 7, 2019
Hey @shigma, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
This was referenced Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
complexity: medium
Medium complexity
effort: low
Around a day or less
status: core team assigned
Core team member assigned
topic: theme
Relates to VuePress theme
type: enhancement
Request to enhance an existing feature
version: 1.x
Relates to version 1 of VuePress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
layoutComponentMap
is generated byreaddirSync
so there is no need to check existence.Layout.vue
does not exist,Layout.path
will always beundefined
, which leads to a confusing warning.Layout.vue
when a customGlobalLayout
is specified.What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: