feat($core): config pattern of resolved files #1705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @eduardcotmrf Thank's for the catch ! Can you just add me a real example that it can be great. And it is perfect ! 👍 |
flozero
added
status: community assigned
kefranabg
approved these changes
Sep 20, 2019
There was a problem hiding this comment.
@eddyerburgh Thanks for this PR !
@f3ltron a scenario is described here
|
can you add into the zh doc too please even if it's in english |
|
Hey, i just came back from paternity leave, sorry for not answering for some time :) |
|
Can you merge it @f3ltron ? |
|
Hey @eduardcotmrf, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚 |
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
The PR fulfills these requirements:
Right now the pattern configuration of what files should be resolved as pages is hardcoded in core module of vuepress (APP.js line 319). The intention it's to open the door to parametrizing this pattern configuration from the siteConfig.
fix #1700
You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes: