Update isActive logic to always checking equality #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current
isActive
checking will fail when a path is prefixed by another. It causes a problem when showing active indicator in the side bar.eg:
Say we have two pages under
api
folder, which areuniwebview.md
anduniwebviewmessage.md
. When accessingapi/uniwebviewmessage.html
, the result when determining side bar active state foruniwebview
page is:routePath: "/api/uniwebviewmessage"
pagePath: "/api/uniwebview"
This leads to both uniwebviewmessage and uniwebview be rendered as actived, which is not correct:
By changing it to
===
, it goes fine. However, I am not sure whether there would be a regression on this change or not, since there seems like lack of tests for this project.