fix: sidebar groups are not opened when directly navigating to these pages (fix #2564)

[echojoshchen]

Summary

What kind of change does this PR introduce? (check at least one)

• Bugfix
• Feature
• Code style update
• Refactor
• Docs
• Build-related changes
• Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

• Yes
• No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

• When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

• Chrome
• Firefox
• Safari
• Edge
• IE

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature
• Related documents have been updated
• Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

[echojoshchen]

#2564

[echojoshchen]

@billyyyyy3320 Thanks for taking a look at this PR! Is there anything blocking this from being merged?

[echojoshchen]

@billyyyyy3320 Could this PR be merged soon? It would help a lot for nested pages

[billyyyyy3320]

Sorry for the very late review. Thanks for the PR, and the functionality looks good to me.

Only a small suggestion, there're too many conditions without comments and variable names for others to understand. Would you like to try the code below

function descendantIsActive (route, item) {
  if (item.type === 'group') {
    const childIsActive = item.path && isActive(route, item.path)
    const grandChildIsActive = item.children.some(child => {
      if (child.type === 'group') {
        return descendantIsActive(route, child)
      } else {
        return child.type === 'page' && isActive(route, child.path)
      }
    })

    return childIsActive || grandChildIsActive
  }
  return false
}

[echojoshchen]

Thanks, I think that's much clearer. I've implemented your suggestion.

[billyyyyy3320]

Thanks!