Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($core): #2627 Dup ID violates HTML5-4 #2650

Merged
merged 4 commits into from
Oct 13, 2020

Conversation

adico1
Copy link
Contributor

@adico1 adico1 commented Oct 9, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome - Version 86.0.4240.75 (Official Build) (x86_64)
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@ktquez
Copy link

ktquez commented Oct 9, 2020

@adico1
We can use the sr-only class used by TailwindCSS and put it in some global vuepress style file.

.sr-only {
  position: absolute;
  width: 1px;
  height: 1px;
  padding: 0;
  margin: -1px;
  overflow: hidden;
  clip: rect(0, 0, 0, 0);
  white-space: nowrap;
  border-width: 0;
}

@adico1 adico1 changed the title #2627 3 10082020 fix($core): #2627 Dup ID violates HTML5-4 Oct 9, 2020
@d-pollard d-pollard self-assigned this Oct 13, 2020
Copy link
Collaborator

@d-pollard d-pollard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@d-pollard d-pollard requested a review from bencodezen October 13, 2020 14:30
Copy link
Member

@bencodezen bencodezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @adico1!

@bencodezen bencodezen merged commit 931e7d9 into vuejs:master Oct 13, 2020
@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 14, 2020

image
Is it bugs? Or design to be like this? @adico1 @bencodezen @ktquez

I don't think this hint is necessary and it's looking good.

@Mister-Hope
Copy link
Contributor

Mister-Hope commented Oct 14, 2020

Hey, I found the problems, it's a internal plugin, why are you placing styles in theme-default? It should be placed under Outboundlink.

Otherwise you are breaking every theme which is not extending @vue/theme-default!!! That will inflect all the docs site which is using CI to update deps for auto-publishing while not using theme-default or a theme extending it.

I will make a PR to fix this. Hope you can release 1.7.1 to fix it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants