Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Last updated" feature is coupled to Git #340

Closed
inosik opened this issue May 4, 2018 · 6 comments
Closed

"Last updated" feature is coupled to Git #340

inosik opened this issue May 4, 2018 · 6 comments

Comments

@inosik
Copy link

inosik commented May 4, 2018

The "Last updated" feature implemented in #282 is tightly coupled to Git.

  • It assumes Git is installed.

  • It assumes the project uses Git. The process will crash if the directory is not a Git repository. This is a serious issue if you're just starting out with documentation in a new directory or if you (have to) use something other than Git.

Also see #282 (comment).

@ulivz
Copy link
Member

ulivz commented May 4, 2018

Thanks for reporting for that.

And I also concerned for that. since I believed that most of users use git so I let it go, but it's truly a potential problem, I will disable it by default.

BTW, we will make this feature as a plugin in the future.

@ulivz
Copy link
Member

ulivz commented May 4, 2018

BTW, You have been saying this question so early 😅 we even haven't released it yet. awesome !

@ulivz
Copy link
Member

ulivz commented May 4, 2018

Fixed at: 4921f99

@jacobmllr95
Copy link

@ulivz What about using mtime from fs.stat() by default (because its always available) and make using the Git last modified timestamp an option?

@ulivz
Copy link
Member

ulivz commented May 4, 2018

@jackmu95 See: #258 (comment)

@ulivz
Copy link
Member

ulivz commented May 8, 2018

Fixed at 272df57 (#338)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants