Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing dropdown overlapping due to word wrapping #360

Merged
merged 1 commit into from
May 8, 2018

Conversation

ycmjason
Copy link
Contributor

@ycmjason ycmjason commented May 7, 2018

Fixing #359

The current style forces the dropdown links to have a fixed height which will cause long lines to overlap to the next line.

This fix removed the fix height and changed the arrow position to calc(line height - 2px)

Briefly tested on desktop and mobile. Please review them. 😄

cc @ulivz @meteorlxy

Copy link
Member

@ulivz ulivz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulivz ulivz merged commit c65a8b7 into vuejs:master May 8, 2018
@ulivz ulivz mentioned this pull request May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants