feat: add type annotation for the context of actions and mutations #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @ktsn |
ktsn
reviewed
Jul 15, 2018
types/index.d.ts
Outdated
| export interface ActionObject<S, R> { | ||
| root?: boolean; | ||
| handler: ActionHandler<S, R>; | ||
| } | ||
|
|
||
| export type Getter<S, R> = (state: S, getters: any, rootState: R, rootGetters: any) => any; | ||
| export type Action<S, R> = ActionHandler<S, R> | ActionObject<S, R>; | ||
| export type Mutation<S> = (state: S, payload: any) => any; | ||
| export type Mutation<S> = (this: Store<S>, state: S, payload: any) => any; |
There was a problem hiding this comment.
What is the use case of this in mutations?
I think we should not use that in mutations while it might be useful in actions.
I think so too. I just followed the implementation. |
|
@sue71 If there are no use case for mutations, can we remove |
|
@ktsn make sense. I'll do so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handlers for actions and mutations are bound to the store, but there is no type annotation for this behavior.
This PR will enable us to use
thisas Store in the handlers.